mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 18403: Added support for launching tasks by TaskInfo.
Date Wed, 19 Mar 2014 19:37:04 GMT


> On March 18, 2014, 9:23 a.m., Ian Downes wrote:
> > Some minor points for consideration.

Thanks for the review Ian! The executor->info change became a bit more substantial change.
Mind taking a second look? 


> On March 18, 2014, 9:23 a.m., Ian Downes wrote:
> > src/slave/slave.hpp, line 460
> > <https://reviews.apache.org/r/18403/diff/5/?file=522998#file522998line460>
> >
> >     Could this not be Future<ExecutorInfo> and then remove the Future<bool>
future below? This better reflects this variable - it's not available until launch is complete,
rather than being optional.

I like it but this became a bigger change; try to take a look at the latest review :)


> On March 18, 2014, 9:23 a.m., Ian Downes wrote:
> > src/slave/slave.hpp, line 417
> > <https://reviews.apache.org/r/18403/diff/5/?file=522998#file522998line417>
> >
> >     Do we really need both of these constructors for Executor?

It was to support recover(). I removed the old one and change the call-site in recover.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/#review37519
-----------------------------------------------------------


On March 19, 2014, 12:31 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18403/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-922
>     https://issues.apache.org/jira/browse/MESOS-922
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch delegates the choice of executor to the containerizer by removing executorInfo
dependencies up until Containerizer::launch().
> Containerizer::launch() now returns a future to the executor info that is being run and
the slave creates the corresponding executor structure when launch completes.
> This means message handling from the running executor to the slave in the interim where
the executor structure has not created, need to be enqueued until executor is ready. So far,
registerExecutor() and reregisterExecutor() has been split into two continuations to deal
with this issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp d9ae326 
>   src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
>   src/slave/containerizer/mesos_containerizer.cpp c819c97 
>   src/slave/http.cpp 594032d 
>   src/slave/slave.hpp 01b80df 
>   src/slave/slave.cpp d8d3e0f 
>   src/tests/containerizer.hpp 5686398 
>   src/tests/containerizer.cpp bfb9341 
> 
> Diff: https://reviews.apache.org/r/18403/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message