mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.
Date Wed, 12 Mar 2014 20:32:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36979
-----------------------------------------------------------

Ship it!


This looks good Tim. I get the feeling that the mesos.pc.in doesn't need to be in this review
though?


mesos.pc.in
<https://reviews.apache.org/r/18910/#comment68205>

    Do you need the newline?


- Benjamin Hindman


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add
the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message