mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 18311: Adds await on a tuple of futures.
Date Tue, 11 Mar 2014 21:48:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/#review36849
-----------------------------------------------------------



3rdparty/libprocess/include/process/collect.hpp
<https://reviews.apache.org/r/18311/#comment68034>

    Now that we've got Future::after, let's kill passing a timeout and let people do it themselves
(kill above too if you don't kill await with just one future).


- Benjamin Hindman


On March 10, 2014, 2:15 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18311/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 2:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently the Process::await implementation on list<Future>, by the nature of std::list,
expects equally typed futures. This new override implements await for a tuple of futures,
hence allows awaiting differently typed futures in a single call.
> 
> There also is a new override that allows await on a single Future, a convenience approach
for allowing a Process based await on a single Future without forcing the user to render a
list or tuple out of that. 
> 
> A C++11 and a boost-based implementation have been added.
> 
> This patch also includes tests on those new overrides.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 2a73bc9 
>   3rdparty/libprocess/src/tests/process_tests.cpp e899aed 
> 
> Diff: https://reviews.apache.org/r/18311/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message