mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 18946: Moved JNI code to separate library
Date Tue, 11 Mar 2014 16:59:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/
-----------------------------------------------------------

(Updated March 11, 2014, 4:59 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

assigning this to myself for shepherding -- Vinod


Bugs: MESOS-855
    https://issues.apache.org/jira/browse/MESOS-855


Repository: mesos-git


Description
-------

Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That 
variable points towards libmesos_java. libmesos_java contains the JNI-
specific code (formally part of libmesos) and dynamically links against 
libmesos.

A typical java-based framework relies on mesos.jar to do the loading 
but may use some extra logic in its startup to make sure 
MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic would need 
to be adapted to use the new environment variable instead of the old 
one.

Note: 
This patch does not remove the MESOS_NATIVE_LIRBRAY variable. It is 
kept for frameworks that are not JVM based but need to bind to the 
self-contained Mesos library. MESOS_NATIVE_LIRBRAY points towards 
libmesos.
MESOS_NATIVE_JAVA_LIBRARY however is the new variant to be used for 
JVM based frameworks.


Diffs
-----

  bin/mesos-slave-flags.sh.in dc73aef 
  src/Makefile.am 384b312 
  src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2 
  src/slave/containerizer/containerizer.cpp d0a1023 
  src/tests/environment.cpp 5c92fcd 

Diff: https://reviews.apache.org/r/18946/diff/


Testing
-------

make check and functional testing with external, java based frameworks


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message