mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 18966: change the datatype of cpushare from size_t to uint64_t because The actual type of size_t is platform-dependent .
Date Tue, 11 Mar 2014 16:41:52 GMT


> On March 11, 2014, 12:14 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> > 
> > Reviews applied: [18966]
> > 
> > All tests passed.
> 
> Archana kumari wrote:
>     So should I ship it now?

Ship its are given by your reviewers :) A project member will commit the patch when it is
ready: http://mesos.apache.org/documentation/latest/mesos-developers-guide/


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18966/#review36762
-----------------------------------------------------------


On March 10, 2014, 11:17 p.m., Archana kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18966/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 11:17 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>  I intend to change the datatype of cpushare from size_t to uint64_t because The actual
type of size_t is platform-dependent 
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e 
> 
> Diff: https://reviews.apache.org/r/18966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Archana kumari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message