mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 19008: Moved LevelDBStorageProcess and ZooKeeperStorageProcess out of the header files.
Date Tue, 11 Mar 2014 04:07:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36756
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19008]

All tests passed.

- Mesos ReviewBot


On March 11, 2014, 3:44 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19008/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 3:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See above, there was no need in this case to expose the Process implementation for these.
> 
> I did this to keep consistency with the new InMemoryStorage layer I am adding.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 154bbc6966a6d3a0f9aa942edcfb8edccd23cea3

>   src/state/leveldb.hpp 14a94ccaceb7f60fea647a2cbda1836af93af3c2 
>   src/state/leveldb.cpp be0df0cf87e54254e067fc308e225e7a304d2086 
>   src/state/zookeeper.hpp cfc883191a07b71bdc301f85063578957846bba7 
>   src/state/zookeeper.cpp 09b63d44e9349cab2d73659c939de3d8e96fbcc5 
> 
> Diff: https://reviews.apache.org/r/19008/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message