mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 18954: Added Future::after.
Date Tue, 11 Mar 2014 01:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18954/#review36739
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 10, 2014, 6:13 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18954/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 6:13 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is to avoid a standard pattern seen with doing a 'delay' after some asynchronous
function call has been made and we're waiting on it's completion via Future::then, onAny,
etc. This allows one to do:
> 
> someAsynchronousFunction()
>   .then(defer(self(), &Self::_continuation1))
>   .then(defer(self(), &Self::_continuation2))
>   .after(Seconds(30), defer(self(), &Self::_timeout, lambda::_1));
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5

>   3rdparty/libprocess/include/process/http.hpp 7f549ba3476ecf5dec0db21d57ee58bcd73d5996

>   3rdparty/libprocess/src/tests/process_tests.cpp e899aed7dbe6e8645484fe0ba69521e9fb0fdad2

> 
> Diff: https://reviews.apache.org/r/18954/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message