mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 18386: Option reference cleanup in mesos.
Date Mon, 10 Mar 2014 22:57:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36726
-----------------------------------------------------------


Patch looks great!

Reviews applied: [18386]

All tests passed.

- Mesos ReviewBot


On March 10, 2014, 8:35 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 8:35 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1008
>     https://issues.apache.org/jira/browse/MESOS-1008
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db 
>   src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426 
>   src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4 
>   src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426 
>   src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5

>   src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848 
>   src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473 
> 
> Diff: https://reviews.apache.org/r/18386/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 'grep' for cases where Options are reassigned after references are taken.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message