mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 17343: Exposed coordinator demotion.
Date Mon, 10 Mar 2014 06:39:23 GMT


> On March 3, 2014, 10:49 p.m., Ben Mahler wrote:
> > src/tests/log_tests.cpp, line 700
> > <https://reviews.apache.org/r/17343/diff/2/?file=497560#file497560line700>
> >
> >     AWAIT_READY uses a default of 10 Seconds, any reason for the explicit duration
here?

AWAIT_READY used to have a lower duration and when it was increased these weren't changed.
:( Alas, I added this to https://reviews.apache.org/r/18263.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/#review36048
-----------------------------------------------------------


On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17343/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 8:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1 
>   src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d 
>   src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5 
>   src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 
>   src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a 
>   src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24 
> 
> Diff: https://reviews.apache.org/r/17343/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message