-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18946/#review36626
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18946]
All tests passed.
- Mesos ReviewBot
On March 10, 2014, 3:27 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18946/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 3:27 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-855
> https://issues.apache.org/jira/browse/MESOS-855
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduced a new environment variable (MESOS_NATIVE_JAVA_LIBRARY). That
> variable points towards libmesos_java. libmesos_java contains the JNI-
> specific code (formally part of libmesos) and dynamically links against
> libmesos.
>
> A typical java-based framework relies on mesos.jar to do the loading
> but may use some extra logic in its startup to make sure
> MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic would need
> to be adapted to use the new environment variable instead of the old
> one.
>
>
> Diffs
> -----
>
> bin/mesos-slave-flags.sh.in dc73aef
> src/Makefile.am 384b312
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2
>
> Diff: https://reviews.apache.org/r/18946/diff/
>
>
> Testing
> -------
>
> make check and functional testing with external, java based frameworks
>
>
> Thanks,
>
> Till Toenshoff
>
>
|