mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikita Vetoshkin" <nikita.vetosh...@gmail.com>
Subject Review Request 18945: Add --version flag to mesos master and slave
Date Sun, 09 Mar 2014 17:29:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18945/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-1068
    https://issues.apache.org/jira/browse/MESOS-1068


Repository: mesos-git


Description
-------

Subj. Looks like a bit copy-paste, please advise where to put this to be shared between slave
and master code.
I can see some useful defines like -DPACKAGE_STRING during build, but I don't see if it's
used somewhere.


Diffs
-----

  src/master/flags.hpp 159b2de5878927613ba94f81005dba601f072026 
  src/master/main.cpp 4c74a1b387dc99aa223cb9cf8a096d3b4a126a0a 
  src/slave/flags.hpp e4d98a53cbfb7f9ca828f17e82d492274cb9969d 
  src/slave/main.cpp a498a6ae6a79c7155c07a5d6dc2d6c9dc8ae060f 

Diff: https://reviews.apache.org/r/18945/diff/


Testing
-------

make check passes, manually tested --version option on master and slave


Thanks,

Nikita Vetoshkin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message