mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 18730: Implemented a basic Authorizer interface.
Date Wed, 05 Mar 2014 17:17:53 GMT


> On March 4, 2014, 9:44 a.m., Dominic Hamon wrote:
> > src/authorizer/authorizer.hpp, line 68
> > <https://reviews.apache.org/r/18730/diff/2/?file=509429#file509429line68>
> >
> >     this should be marked explicit to avoid unwanted implicit conversion.
> 
> Vinod Kone wrote:
>     We havent' followed this convention in the code base unless specifically needed.
For consistency, I'll drop this.

For consistency, I agree. I'll just point out that you wouldn't notice it was needed until
you hit the bugs it can cause. Maybe something else to open up as an 'improvement' ticket.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/#review36120
-----------------------------------------------------------


On March 4, 2014, 3:27 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18730/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 3:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-911
>     https://issues.apache.org/jira/browse/MESOS-911
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 
>   src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4 
>   src/authorizer/authorizer.hpp PRE-CREATION 
>   src/tests/authorization_tests.cpp PRE-CREATION 
>   src/tests/master_contender_detector_tests.cpp 8da7420e18c7a960b566fae13a5975857eb777ee

> 
> Diff: https://reviews.apache.org/r/18730/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message