mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 18700: JSON parsing and equality.
Date Tue, 04 Mar 2014 22:07:34 GMT


> On March 3, 2014, 6:58 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 168
> > <https://reviews.apache.org/r/18700/diff/1/?file=508464#file508464line168>
> >
> >     why not dynamic_cast<T> for here and as()?

Unless I'm missing something that's not how boost variant is implemented and you're supposed
to use boost::get.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18700/#review36004
-----------------------------------------------------------


On March 3, 2014, 6:50 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18700/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 6:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 778398af0e166709a777d770b7fddda309a60add

>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 5b7cbb9b42aaa0dc4f3e732d4ceae496bcb15ea6

> 
> Diff: https://reviews.apache.org/r/18700/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message