mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 18701: JSON to protobuf parsing.
Date Mon, 03 Mar 2014 19:04:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18701/#review36007
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/18701/#comment66800>

    probably a good idea to ensure these are prefixed with stout/ to avoid bringing in includes
from other paths by mistake.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/18701/#comment66798>

    Is this ever anything other than protobuf::Message?


- Dominic Hamon


On March 3, 2014, 10:51 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18701/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 10:51 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 74aec7a5645697e578f64c9432d6e9990340da25

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 02bbf749c6f0aa190214b616799e246400ce5397

> 
> Diff: https://reviews.apache.org/r/18701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message