Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECA7410716 for ; Mon, 10 Feb 2014 22:27:50 +0000 (UTC) Received: (qmail 37899 invoked by uid 500); 10 Feb 2014 22:27:49 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 37857 invoked by uid 500); 10 Feb 2014 22:27:49 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 37844 invoked by uid 99); 10 Feb 2014 22:27:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Feb 2014 22:27:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5C3941D4887; Mon, 10 Feb 2014 22:27:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6720640587558474562==" MIME-Version: 1.0 Subject: Re: Review Request 17564: Introduce a repair coordinator class to master. From: "Charlie Carson" To: "Benjamin Hindman" , "Jeff Currier" , "Vinod Kone" Cc: "Charlie Carson" , "mesos" Date: Mon, 10 Feb 2014 22:27:48 -0000 Message-ID: <20140210222748.9701.97022@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Charlie Carson" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/17564/ X-Sender: "Charlie Carson" References: <20140131001842.22330.87268@reviews.apache.org> In-Reply-To: <20140131001842.22330.87268@reviews.apache.org> Reply-To: "Charlie Carson" X-ReviewRequest-Repository: mesos-git --===============6720640587558474562== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17564/ ----------------------------------------------------------- (Updated Feb. 10, 2014, 10:27 p.m.) Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone. Bugs: https://issues.apache.org/jira/browse/MESOS-957 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957 Repository: mesos-git Description ------- Introduce a repair coordinator class to master. Add a RepairCoordinator class to master. Currently it is just a stub, but it will soon get wired up to the new observe end-point in master and recieve slave state updates. From there, it will be responsible for persisting the state and ultimately performing repairs on unhealthy slaves. The RepairCoordinator has virtual methods and destructor so that it can easily be mocked for testing. Updated the existing master constructor to take a RepairCoordinator* and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new up a RepairCoordinator, pass it to master's constructor and delete the RepairCoordinator when it's finished. Diffs (updated) ----- src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 src/master/main.cpp 4f1859fba15c3f6c581d098337dc3262ec68bf3c src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559 src/master/repair_coordinator.hpp PRE-CREATION src/master/repair_coordinator.cpp PRE-CREATION src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 Diff: https://reviews.apache.org/r/17564/diff/ Testing ------- make check Thanks, Charlie Carson --===============6720640587558474562==--