Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3893F10BED for ; Thu, 6 Feb 2014 23:44:32 +0000 (UTC) Received: (qmail 3199 invoked by uid 500); 6 Feb 2014 23:44:31 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 3146 invoked by uid 500); 6 Feb 2014 23:44:31 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 3133 invoked by uid 99); 6 Feb 2014 23:44:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Feb 2014 23:44:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1CEDD1D4761; Thu, 6 Feb 2014 23:44:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5622079202294523200==" MIME-Version: 1.0 Subject: Re: Review Request 16432: Containerizer - cgroup isolators (part 4) From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" , samyad@gmail.com, "Chi Zhang" Cc: "mesos" , "Ian Downes" Date: Thu, 06 Feb 2014 23:44:26 -0000 Message-ID: <20140206234426.17020.42496@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/16432/ X-Sender: "Vinod Kone" References: <20140206053749.1219.23895@reviews.apache.org> In-Reply-To: <20140206053749.1219.23895@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============5622079202294523200== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16432/#review33865 ----------------------------------------------------------- Ship it! src/slave/containerizer/isolators/cgroups/cgroups.cpp does it fit on the same line? src/slave/containerizer/isolators/cgroups/cgroups.cpp ditto. src/slave/containerizer/isolators/cgroups/cpushare.cpp s/VLOG/LOG(INFO)/ ? src/slave/containerizer/isolators/cgroups/mem.cpp ditto. - Vinod Kone On Feb. 6, 2014, 5:37 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16432/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 5:37 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, samya, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Forth part of isolation refactor - cgroup isolators > > CPU and Memory isolators using Linux cgroups. > > This code was written by Chi Zhang and based on the original cgroups_isolator. > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/slave/containerizer/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/cpushare.cpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/mem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16432/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============5622079202294523200==--