Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9A0F1010A for ; Wed, 5 Feb 2014 23:23:57 +0000 (UTC) Received: (qmail 3603 invoked by uid 500); 5 Feb 2014 23:23:56 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 3566 invoked by uid 500); 5 Feb 2014 23:23:56 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 3553 invoked by uid 99); 5 Feb 2014 23:23:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 23:23:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B92B1D47A9; Wed, 5 Feb 2014 23:23:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8455070611512997206==" MIME-Version: 1.0 Subject: Re: Review Request 17755: Added a log tool to start a replica server. From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Jie Yu" , "mesos" Date: Wed, 05 Feb 2014 23:23:56 -0000 Message-ID: <20140205232356.1218.34703@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/17755/ X-Sender: "Vinod Kone" References: <20140205205440.1218.26831@reviews.apache.org> In-Reply-To: <20140205205440.1218.26831@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============8455070611512997206== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17755/#review33735 ----------------------------------------------------------- Is there a different tool that does the writes? src/log/tool/replica.hpp Why are these optional? src/log/tool/replica.cpp If you make these variables not options, these checks come for free. - Vinod Kone On Feb. 5, 2014, 8:54 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17755/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 8:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. This is the useful for performing distributed tests on the replicated log. > > > Diffs > ----- > > src/Makefile.am c307068 > src/log/main.cpp c37dd6f > src/log/tool/replica.hpp PRE-CREATION > src/log/tool/replica.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17755/diff/ > > > Testing > ------- > > make check > > Also, run the command on test machines > > > Thanks, > > Jie Yu > > --===============8455070611512997206==--