mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18639: Fixed Cpu isolator to use integral values for cfs quota.
Date Fri, 28 Feb 2014 19:55:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18639/#review35828
-----------------------------------------------------------


The story to prevent regression leaves much to be desired.  Can this really not be tripped
in a unit test?  What if you abstract cgroups with a small wrapper that you can mock?  Barring
that, a ticket to track the test coverage is warranted (but test coverage here would be better).

- Bill Farner


On Feb. 28, 2014, 7:50 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18639/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 7:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1049
>     https://issues.apache.org/jira/browse/MESOS-1049
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 160e8fe5eb06a2f65924734157b7b8d468d8be36

> 
> Diff: https://reviews.apache.org/r/18639/diff/
> 
> 
> Testing
> -------
> 
> Verified manually by changing the cpu shares to 13.5 in LimitedCpuIsolatorTest.
> 
> Didn't change the test in this diff because I want to come up with a test that runs for
all users and doesn't take too much time.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message