mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 18341: Modified the Registrar to notify callers only _after_ the storage operation completes.
Date Wed, 26 Feb 2014 02:19:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18341/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 2:19 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

A discarded storage operation now results in a Failure for the caller of the Registrar.


Bugs: MESOS-764
    https://issues.apache.org/jira/browse/MESOS-764


Repository: mesos-git


Description
-------

We previously were setting the Promises in some cases _before_ writing to storage. While this
approach was correct, it requires some time and explanation to convince oneself of this.

This is why this patch simplifies the semantics by only setting the Promises _after_ we've
written to storage.

Also, 'Mutation' has now become 'Operation' to better reflect the fact that some operations
do not mutate state when applied.


Diffs (updated)
-----

  src/master/registrar.cpp ee16121035db21d966ee151483dd23cbc4a495c2 

Diff: https://reviews.apache.org/r/18341/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message