mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 18384: Option reference cleanup in process
Date Tue, 25 Feb 2014 00:01:54 GMT


> On Feb. 24, 2014, 3:48 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/future.hpp, lines 601-602
> > <https://reviews.apache.org/r/18384/diff/1/?file=500694#file500694line601>
> >
> >     I had been using "_foo" for these kinds of variables as well. After discussing
with benh we really wanted these to be read as "foo prime", so we felt the suffix was more
appropriate (although you'll find a lot of code that doesn't follow this, as usual ;)).

my muscle memory is to use the _ suffix for private member variables (a la Google-style) so
it is reserved for that in my mind.

I was going to suggest adopting that at some point, as i currently find myself checking if
a variable is local scope or member quite often.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18384/#review35337
-----------------------------------------------------------


On Feb. 24, 2014, 4:01 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18384/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 4:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1008
>     https://issues.apache.org/jira/browse/MESOS-1008
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp e45f4f79faeefbffc28d855d2f74e8df69099f18

> 
> Diff: https://reviews.apache.org/r/18384/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message