mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 18361: Implemented MESOS-945: Added hostname attribute to framework, display it in master's web ui
Date Mon, 24 Feb 2014 15:03:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18361/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 7:03 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fixed review issues.


Repository: mesos-git


Description
-------

- Added a field to FrameworkInfo in protobuf spec 
- Added table fields in html of web ui that display framework's hostname for running and terminated
frameworks
- Added line to scheduler constructor that sets framework hostname. This is just about the
first centralized piece of code that every framework executes.
- Refactored scheduler constructor so that code duplication is avoided.


Diffs (updated)
-----

  include/mesos/mesos.proto 69a4a60 
  include/mesos/scheduler.hpp 2e4707e 
  src/master/http.cpp c941274 
  src/sched/sched.cpp dcb3158 
  src/slave/http.cpp 7c4cfba 
  src/webui/master/static/frameworks.html 8686b00 

Diff: https://reviews.apache.org/r/18361/diff/


Testing
-------

Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test frameworks. Observed
new hostname display in web UI. Built Mesos on Ubuntu 13.10 with gcc 4.8.1.


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message