mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 17476: Added a Sequence abstraction.
Date Fri, 21 Feb 2014 01:23:29 GMT


> On Feb. 21, 2014, 1:03 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/sequence.hpp, line 151
> > <https://reviews.apache.org/r/17476/diff/4/?file=499673#file499673line151>
> >
> >     Can you use an owned pointer for the process to save the explicit delete call
in the destructor?

Hum. It's tricky because process::spawn does not accept an Owned pointer.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17476/#review35118
-----------------------------------------------------------


On Feb. 21, 2014, 12:56 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17476/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 12:56 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> One think I haven't done yet is to make it accepts '_Defer' types. (Just curious why
Future.onAny can accept defer without doing something special).
> 
> Also, we can get rid of the SequencerProcess if we use a mutex to protect 'last'. Not
sure which one is better.
> 
> The discard semantics here is a bit tricky. Basically, I wanna support discarding a single
callback without affecting other callbacks. Also, when the Sequencer object is deleted, I
wanna discard all the pending callbacks.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am a7d199f 
>   3rdparty/libprocess/include/process/sequence.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/sequence_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17476/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> repeated 1000 times
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message