mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TILL TOENSHOFF" <toensh...@me.com>
Subject Re: Review Request 18311: Adds await on a tuple of futures.
Date Thu, 20 Feb 2014 16:46:47 GMT


> On Feb. 20, 2014, 4:37 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/collect.hpp, line 2
> > <https://reviews.apache.org/r/18311/diff/1/?file=498993#file498993line2>
> >
> >     possibly naive question: instead of having a full copy of this header with the
type changed, would it be possible to just typedef 'process::tuple' or add a 'stout::tuple'
that is either a boost::tuples::tuple or std::tuple?

There is a point in what you say, but it wont fix things entirely.

The C++11 implementation makes use of "proper" lambdas, the other implementation does not
but emulates those by the use of _await and _then.

However, pulling boost::tupes::tuple or std::tuple into the libprocess namespace depending
on the availability is a good idea (unless it clashes at a point I dont see right now). I
will suggest another RR and adapt this one to make use of this once that is done.


- TILL


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18311/#review35007
-----------------------------------------------------------


On Feb. 20, 2014, 3:59 p.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18311/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 3:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod
Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently the Process::await implementation on list<Future>, by the nature of std::list,
expects equally typed futures. This new override implements await for a tuple of futures,
hence allows awaiting differently typed futures in a single call.
> 
> A C++11 and a boost-based implementation have been added.
> 
> This patch also includes tests on that new feature.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/collect.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/collect.hpp 2a73bc9 
>   3rdparty/libprocess/src/tests/process_tests.cpp e899aed 
> 
> Diff: https://reviews.apache.org/r/18311/diff/
> 
> 
> Testing
> -------
> 
> make check (clang c++11, gcc)
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message