mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikita Vetoshkin" <nikita.vetosh...@gmail.com>
Subject Re: Review Request 18272: Add -lgflags to linker flags when building python extension module
Date Wed, 19 Feb 2014 20:12:53 GMT


> On Feb. 19, 2014, 7:54 p.m., Vinod Kone wrote:
> > src/python/setup.py.in, line 90
> > <https://reviews.apache.org/r/18272/diff/1/?file=497647#file497647line90>
> >
> >     Hmm. This actually doesn't work on my box because it cannot find -lgflags. I'm
assuming this is because we build gflags and it's not in the path searched by "ld".
> >     
> >     g++ -pthread -shared build/temp.linux-x86_64-2.6/native/proxy_scheduler.o build/temp.linux-x86_64-2.6/native/module.o
build/temp.linux-x86_64-2.6/native/mesos_scheduler_driver_impl.o build/temp.linux-x86_64-2.6/native/mesos_executor_driver_impl.o
build/temp.linux-x86_64-2.6/native/proxy_executor.o /home/vinod/mesos/build/src/.libs/libmesos_no_3rdparty.a
/home/vinod/mesos/build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/.libs/libprotobuf.a
/home/vinod/mesos/build/3rdparty/leveldb/libleveldb.a /home/vinod/mesos/build/3rdparty/zookeeper-3.4.5/src/c/.libs/libzookeeper_mt.a
/home/vinod/mesos/build/3rdparty/libprocess/.libs/libprocess.a /home/vinod/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/.libs/libglog.a
/home/vinod/mesos/build/3rdparty/libprocess/3rdparty/libev-4.15/.libs/libev.a -L/usr/lib64
-lpython2.6 -o build/lib.linux-x86_64-2.6/_mesos.so -lgflags -lsasl2 -lcurl -lz -lrt -lunwind
> >
> 
> Vinod Kone wrote:
>     sorry my comment got truncated. here is the rest of it.
>     
>     /usr/bin/ld: cannot find -lgflags
>     collect2: ld returned 1 exit status
>     error: command 'g++' failed with exit status 1
>     make[2]: *** [python/dist/mesos-0.19.0-py2.6-linux-x86_64.egg] Error 1
>     make[2]: *** Waiting for unfinished jobs....
>

Looks like this review should be dropped as well as the issue itself.


- Nikita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18272/#review34906
-----------------------------------------------------------


On Feb. 19, 2014, 3:57 p.m., Nikita Vetoshkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18272/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 3:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1010
>     https://issues.apache.org/jira/browse/MESOS-1010
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Could find a better way to pass this flag. Seems pretty legit.
> 
> 
> Diffs
> -----
> 
>   src/python/setup.py.in 02f00ef9e26399fcaf945b362eac9552a06f1cec 
> 
> Diff: https://reviews.apache.org/r/18272/diff/
> 
> 
> Testing
> -------
> 
> Built locally with and without this flag.
> 
> 
> Thanks,
> 
> Nikita Vetoshkin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message