mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 17686: Updated Mesos to use new libprocess discard semantics.
Date Tue, 18 Feb 2014 08:44:56 GMT


> On Feb. 7, 2014, 7:12 a.m., Adam B wrote:
> > Can you give a high-level overview/description of what these changes accomplish?
Best I can tell, now you can call discard on a promise itself, without having to go through
to its future; plus s/onDiscarded/onDiscard/ and s/isDiscarded/hasDiscard/. Is there any functional
difference beyond the renaming and syntactic sugar?

Check out the summary of https://reviews.apache.org/r/17685 for the context (sorry I forgot
to make this review dependent on that one).


> On Feb. 7, 2014, 7:12 a.m., Adam B wrote:
> > src/java/jni/org_apache_mesos_state_AbstractState.cpp, line 99
> > <https://reviews.apache.org/r/17686/diff/3/?file=470405#file470405line99>
> >
> >     Always false, no bothering to check the future?

Please see the comments below in Jie Yu's review!


> On Feb. 7, 2014, 7:12 a.m., Adam B wrote:
> > src/sasl/authenticatee.hpp, lines 176-177
> > <https://reviews.apache.org/r/17686/diff/3/?file=470412#file470412line176>
> >
> >     Could future-observers have stopped caring before we bothered to do the sasl
work above?

If they did stop caring via a Future::discard then our 'defer' here will execute immediately.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17686/#review33914
-----------------------------------------------------------


On Feb. 5, 2014, 11:41 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17686/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 11:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas Nielsen, TILL
TOENSHOFF, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 2ee0b1b631b80ec783e6bce683cdeaa77e56b2aa

>   src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a 
>   src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c 
>   src/log/consensus.cpp b89673a3b8f233e901eaf9ae69a9979099f4eb73 
>   src/log/recover.cpp bb32e51e1172a8b32ac74be9848c1e72db5cefa0 
>   src/master/detector.cpp 2b169c551affe7acd2feac7806a27b46eb99bb88 
>   src/master/registrar.cpp 915885a160f790399e8185c28c6e6555af1ee76e 
>   src/sasl/authenticatee.hpp f1a677f8aed0979f958e51f85e0a8210a03bd343 
>   src/sasl/authenticator.hpp 1478f6771b424555c34586a0d61f208dc15b0e7d 
>   src/slave/gc.cpp 405350bf8f498d2e59e9e6b4c4c19b7bdaa974de 
>   src/zookeeper/contender.cpp 6710da4e64fc0a43c1eabfc0f39fb0133c13df14 
>   src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3 
> 
> Diff: https://reviews.apache.org/r/17686/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message