mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 18062: Used interval set to store holes and unlearned positions in replica.
Date Thu, 13 Feb 2014 19:04:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18062/#review34400
-----------------------------------------------------------

Ship it!


Looks good but looking forward to the abstraction.


src/log/replica.cpp
<https://reviews.apache.org/r/18062/#comment64486>

    It would be great to invert these to 'unlearned.contains(position)' and 'holes.contains(position)'
with the IntervalSet abstraction.



src/log/replica.cpp
<https://reviews.apache.org/r/18062/#comment64488>

    Please adjust the comment to better reflect what you're doing.


- Benjamin Hindman


On Feb. 13, 2014, 7:27 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18062/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 7:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-993
>     https://issues.apache.org/jira/browse/MESOS-993
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed the problem in MESOS-993.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz 770d837aaba23d031b04ad77658f339587174aae

>   src/log/catchup.hpp c72ed81 
>   src/log/catchup.cpp 4ee32f2 
>   src/log/coordinator.cpp bc85e66 
>   src/log/recover.cpp bb32e51 
>   src/log/replica.hpp 467d0d9 
>   src/log/replica.cpp ec6e38c 
>   src/log/storage.hpp 663146f 
>   src/tests/log_tests.cpp b1fb200 
> 
> Diff: https://reviews.apache.org/r/18062/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message