mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikita Vetoshkin" <nikita.vetosh...@gmail.com>
Subject Re: Review Request 18001: Disable SIGPIPE on MacOS upon socket creation
Date Thu, 13 Feb 2014 07:06:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18001/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 7:06 a.m.)


Review request for mesos.


Changes
-------

Moved process::socket to socket.hpp, addressed review comments and fixed two tests (which
were broken by prev diff).


Bugs: MESOS-912
    https://issues.apache.org/jira/browse/MESOS-912


Repository: mesos-git


Description
-------

Following the discussion in JIRA - disable SIGPIPE on MacOS via setsockopt as it doesn't support
MSG_NOSIGNAL.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/socket.hpp 669a3334629e15b420ea8332e31cd0306d52066b

  3rdparty/libprocess/src/process.cpp 2e7764a8e0badec704b8610f3f72f0bd16cc9612 
  3rdparty/libprocess/src/tests/http_tests.cpp 62ab64d81c11ab7260620c91100b7e1f29b81e33 
  3rdparty/libprocess/src/tests/process_tests.cpp be288c353dce78ef641708646979e2e4f3f2c504


Diff: https://reviews.apache.org/r/18001/diff/


Testing
-------

None.


Thanks,

Nikita Vetoshkin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message