mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 17858: Made Group's state transitions monotonic except when expiration happens it is reset to the initial state to start over (DISCONNECTED).
Date Mon, 10 Feb 2014 22:51:28 GMT


> On Feb. 10, 2014, 2:43 p.m., Vinod Kone wrote:
> > src/zookeeper/group.hpp, line 259
> > <https://reviews.apache.org/r/17858/diff/1/?file=480332#file480332line259>
> >
> >     Maybe call it INIT?
> >     
> >     Not clear what is the difference between DISCONNECTED and CONNECTING.

This was the original code and I removed it before because the DISCONNECTED state was never
checked against and not distinguished from CONNECTING.

It's added back only because
1) ZooKeeperStorage has also defines it.
2) In Group:Group() is looks a bit odd to have 'zk' being NULL and state being 'CONNECTING'.
One can say strictly speaking you have to initiate 'zk' to have it 'connecting' to the ZooKeeper
cluster.

zk(NULL),
state(CONNECTING),


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17858/#review34122
-----------------------------------------------------------


On Feb. 7, 2014, 2 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17858/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 2 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - Reconnecting does not reset the state to CONNECTING now. The steps the group has taken
to set up the group are remembered (thus not redone) across reconnections.
> - Improved comments on state transitions.
> - Added the DISCONNECTED state back for the parity between Group and ZooKeeperStorage.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.hpp e51ebb2cf5f09a633462c101f913ee8272be9a6c 
>   src/zookeeper/group.cpp a61a384510c54c152fcf330003e315b870f43bc8 
> 
> Diff: https://reviews.apache.org/r/17858/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message