mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charlie Carson" <charliecar...@gmail.com>
Subject Re: Review Request 17564: Introduce a repair coordinator class to master.
Date Mon, 10 Feb 2014 22:27:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 10:27 p.m.)


Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.


Bugs: https://issues.apache.org/jira/browse/MESOS-957
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957


Repository: mesos-git


Description
-------

Introduce a repair coordinator class to master.

    Add a RepairCoordinator class to master.  Currently it is just
    a stub, but it will soon get wired up to the new observe end-point
    in master and recieve slave state updates.  From there, it will be
    responsible for persisting the state and ultimately performing
    repairs on unhealthy slaves.

    The RepairCoordinator has virtual methods and destructor so that
    it can easily be mocked for testing.

    Updated the existing master constructor to take a RepairCoordinator*
    and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
    up a RepairCoordinator, pass it to master's constructor and delete
    the RepairCoordinator when it's finished.


Diffs (updated)
-----

  src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 
  src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 
  src/master/main.cpp 4f1859fba15c3f6c581d098337dc3262ec68bf3c 
  src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b 
  src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559 
  src/master/repair_coordinator.hpp PRE-CREATION 
  src/master/repair_coordinator.cpp PRE-CREATION 
  src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 

Diff: https://reviews.apache.org/r/17564/diff/


Testing
-------

make check


Thanks,

Charlie Carson


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message