mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 16147: Containerizer (part 1)
Date Fri, 07 Feb 2014 00:55:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16147/#review33880
-----------------------------------------------------------



src/launcher/fetcher.cpp
<https://reviews.apache.org/r/16147/#comment63574>

    Wrap line.



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/16147/#comment63575>

    Wrap line.



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/16147/#comment63573>

    This is unfortunately not enough to silence gcc version 4.8.1 (Ubuntu/Linaro 4.8.1-10ubuntu9).
    Think you actually need to read the value:
    
    ssize_t written = ...
    (void)written;



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/16147/#comment63577>

    Wrap line.


- Niklas Nielsen


On Feb. 5, 2014, 9:34 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16147/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 9:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas Nielsen, samya,
and Jason Dusek.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The proposed Containerizer interface is to replace the existing Isolator. 
> 
> One ContainerizerProcess has been written:
> MesosContainerizerProcess - implements containerizeration internally using a Launcher
and one or more Isolators (following review)
> 
> The intent is to also support a generic ExternalContainerizerProcess that can delegate
containerizeration by making external calls. Other Containerizers could interface with specific
external containerization techniques such as Docker or LXC.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1503e73f0d299f8efb209e0b10966c9a7f8db5f8 
>   src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 
>   src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8 
>   src/launcher/fetcher.cpp PRE-CREATION 
>   src/launcher/launcher.hpp 104fe812ddd2b75b14ec0b40d192f58cdba3603a 
>   src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af 
>   src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf 
>   src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 
>   src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 
>   src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 
>   src/slave/containerizer/containerizer.hpp PRE-CREATION 
>   src/slave/containerizer/containerizer.cpp PRE-CREATION 
>   src/slave/containerizer/mesos_containerizer.hpp PRE-CREATION 
>   src/slave/containerizer/mesos_containerizer.cpp PRE-CREATION 
>   src/slave/flags.hpp 827b2d0d6dc8fa279f3187a09e5dc6d4799d17cd 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
>   src/slave/isolator.hpp 9634535d8c746597b4bb6e278587a1b9ca8f1608 
>   src/slave/isolator.cpp c9643cf9c5657bc142482a71fb161233bffb3b9f 
>   src/slave/main.cpp e0cae7b205c2599e05c4db990cc9c8e9e3673c37 
>   src/slave/monitor.hpp b677410e20eeafa7eac9acb4e687af7c8d53809f 
>   src/slave/monitor.cpp bb3723e967b0723bc2b925019b6e9c4170dcc071 
>   src/slave/paths.hpp 70ee0f31ebb294011e5ec6b05ce3ad28b2c4bacc 
>   src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c 
>   src/slave/process_isolator.cpp 09cb9968c914a095b5737b70bf5044865fc3a2c4 
>   src/slave/slave.hpp 891c874397f5add9b70432c40c152f7f19922e34 
>   src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4 
>   src/slave/state.hpp 78b20ffae1f2f629d851784302648e3bf5349321 
>   src/slave/state.cpp 6c382cd30602ede60b7d526acc272adc16285a93 
>   src/slave/status_update_manager.hpp 06ea4659cdd24cb1b82f389f404566ba14a663fb 
>   src/slave/status_update_manager.cpp 03f5eafefd6ed748bfd4511d654c23c7b460db66 
> 
> Diff: https://reviews.apache.org/r/16147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message