mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 16432: Containerizer - cgroup isolators (part 4)
Date Thu, 06 Feb 2014 23:44:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16432/#review33865
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/cgroups/cgroups.cpp
<https://reviews.apache.org/r/16432/#comment63522>

    does it fit on the same line?



src/slave/containerizer/isolators/cgroups/cgroups.cpp
<https://reviews.apache.org/r/16432/#comment63523>

    ditto.



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/16432/#comment63524>

    s/VLOG/LOG(INFO)/ ?



src/slave/containerizer/isolators/cgroups/mem.cpp
<https://reviews.apache.org/r/16432/#comment63528>

    ditto.


- Vinod Kone


On Feb. 6, 2014, 5:37 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16432/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 5:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, samya, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Forth part of isolation refactor - cgroup isolators
> 
> CPU and Memory isolators using Linux cgroups.
> 
> This code was written by Chi Zhang <czhang@twitter.com> and based on the original
cgroups_isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 
>   src/slave/containerizer/isolators/cgroups/cgroups.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/cgroups.cpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/mem.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/mem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16432/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message