mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 17755: Added a log tool to start a replica server.
Date Wed, 05 Feb 2014 23:23:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17755/#review33735
-----------------------------------------------------------


Is there a different tool that does the writes?


src/log/tool/replica.hpp
<https://reviews.apache.org/r/17755/#comment63367>

    Why are these optional?
    



src/log/tool/replica.cpp
<https://reviews.apache.org/r/17755/#comment63366>

    If you make these variables not options, these checks come for free.


- Vinod Kone


On Feb. 5, 2014, 8:54 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17755/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. This is the useful for performing distributed tests on the replicated log.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c307068 
>   src/log/main.cpp c37dd6f 
>   src/log/tool/replica.hpp PRE-CREATION 
>   src/log/tool/replica.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17755/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also, run the command on test machines
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message