mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 17620: Added io::splice (C++11).
Date Sat, 01 Feb 2014 00:14:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17620/#review33368
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/io.hpp
<https://reviews.apache.org/r/17620/#comment62828>

    Add a note about the need for non-blocking descriptors?



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/17620/#comment62826>

    Maybe a comment somewhere that we're only ever doing a write or a read, but never both
at the same time, which is why 'data' is safe to pass to both?



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/17620/#comment62820>

    Don't both io::read and io::write guarantee that they will not discard the returned future?
(Maybe we should document that).



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/17620/#comment62822>

    Ditto here, just curious why you chose to handle this?



3rdparty/libprocess/src/tests/io_tests.cpp
<https://reviews.apache.org/r/17620/#comment62827>

    "temporary"


- Ben Mahler


On Jan. 31, 2014, 10:02 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17620/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 10:02 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary (C++03 refactor in https://reviews.apache.org/r/17621).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 8cf3244e55da95654cea34471ee1eea5e19c872e

>   3rdparty/libprocess/src/process.cpp 1083a35a0fef48d5f790ec49305a56fd7ef451d5 
>   3rdparty/libprocess/src/tests/io_tests.cpp ee5b0b4d22a4bfcac7140f87924964b8dfb50ac6

> 
> Diff: https://reviews.apache.org/r/17620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message