Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90FC810182 for ; Sun, 26 Jan 2014 08:08:20 +0000 (UTC) Received: (qmail 10958 invoked by uid 500); 26 Jan 2014 08:08:19 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 10701 invoked by uid 500); 26 Jan 2014 08:08:18 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 10682 invoked by uid 99); 26 Jan 2014 08:08:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Jan 2014 08:08:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CB6991C05B2; Sun, 26 Jan 2014 08:08:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1484600387764800143==" MIME-Version: 1.0 Subject: Re: Review Request 16150: Containerizer - isolators (part 3) From: "Adam B" To: "Benjamin Hindman" , "Chi Zhang" , samyad@gmail.com, "Niklas Nielsen" , "Ben Mahler" , "Jason Dusek" Cc: "Adam B" , "mesos" , "Ian Downes" Date: Sun, 26 Jan 2014 08:08:15 -0000 Message-ID: <20140126080815.13730.38894@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Adam B" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/16150/ X-Sender: "Adam B" References: <20140121193450.11320.64220@reviews.apache.org> In-Reply-To: <20140121193450.11320.64220@reviews.apache.org> Reply-To: "Adam B" X-ReviewRequest-Repository: mesos-git --===============1484600387764800143== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review32792 ----------------------------------------------------------- Ship it! Looks great! src/slave/container/isolator.hpp "states" plural src/slave/container/isolator.hpp Should the CommandInfo comment go with the isolate() method that returns the CommandInfo? src/slave/container/isolator.cpp Needs newline at end of file src/slave/container/isolators/posix.hpp Neither parameter is used here. Could you comment why update does nothing? - Adam B On Jan. 21, 2014, 11:34 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 11:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no isolation, just usage()) > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/container/isolator.hpp PRE-CREATION > src/slave/container/isolator.cpp PRE-CREATION > src/slave/container/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============1484600387764800143==--