Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6156954225187210029=="
MIME-Version: 1.0
Subject: Re: Review Request 16634: Added free and total memory in master and
 slave
 stats end-points.
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "Niklas Nielsen" <nik@qni.dk>, "mesos" <dev@mesos.apache.org>
Date: Tue, 21 Jan 2014 19:13:02 -0000
Message-ID: <20140121191302.28235.45623@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vinod Kone" <noreply@reviews.apache.org>
References: <20140113221132.26519.85689@reviews.apache.org>
In-Reply-To: <20140113221132.26519.85689@reviews.apache.org>
Reply-To: "Vinod Kone" <vinodkone@gmail.com>

--===============6156954225187210029==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16634/#review32399
-----------------------------------------------------------

Ship it!


Can you assign the ticket to yourself and mark the fix version as 0.17.0? Thanks.

- Vinod Kone


On Jan. 13, 2014, 10:11 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16634/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 10:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose the number bytes of total and free memory in the
> master and slave stats endpoints.
> Similar to https://reviews.apache.org/r/16631/, the new fields are
> named system_mem_total and system_mem_free to disambiguate the
> aggregate mem_total, mem_used, ... in the master stats endpoint.
> Again, I am open to another naming scheme.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d7cd89f 
>   src/slave/http.cpp 1358810 
> 
> Diff: https://reviews.apache.org/r/16634/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing of /stats.json endpoints.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


--===============6156954225187210029==--