Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39569104B6 for ; Thu, 16 Jan 2014 07:04:57 +0000 (UTC) Received: (qmail 93861 invoked by uid 500); 16 Jan 2014 07:04:56 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 93606 invoked by uid 500); 16 Jan 2014 07:04:56 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 93596 invoked by uid 99); 16 Jan 2014 07:04:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2014 07:04:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD3181CCAEA; Thu, 16 Jan 2014 07:04:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4012494264293249572==" MIME-Version: 1.0 Subject: Re: Review Request 16824: Fixed flaky GroupTest.RetryableErrors test. From: "Jiang Yan Xu" To: "Ben Mahler" Cc: "Jiang Yan Xu" , "mesos" Date: Thu, 16 Jan 2014 07:04:54 -0000 Message-ID: <20140116070454.26245.5733@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/16824/ X-Sender: "Jiang Yan Xu" References: <20140115233822.11940.37101@reviews.apache.org> In-Reply-To: <20140115233822.11940.37101@reviews.apache.org> Reply-To: "Jiang Yan Xu" X-ReviewRequest-Repository: mesos-git --===============4012494264293249572== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 15, 2014, 3:38 p.m., Ben Mahler wrote: > > src/tests/group_tests.cpp, lines 372-373 > > > > > > Should these be re-ordered? The two futures become ready in reaction to group.join() and server->expireSession() and can occur in either order in theory so I think it's fine. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/#review31961 ----------------------------------------------------------- On Jan. 13, 2014, 5:33 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16824/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 5:33 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-871 > https://issues.apache.org/jira/browse/MESOS-871 > > > Repository: mesos-git > > > Description > ------- > > I plan on investigating the "pure virtual method called terminate called without an active exception" problem further but this patch for now prevents GroupTest.RetryableErrors from stopping our Jenkins tests because of its failure. > > > Diffs > ----- > > src/tests/group_tests.cpp 957256e68ab8c69309b15d9e20fab8b70fa9f0a6 > > Diff: https://reviews.apache.org/r/16824/diff/ > > > Testing > ------- > > make check on jenkins/fedora-19-gcc multiple runs, each run 50 iterations. > > > Thanks, > > Jiang Yan Xu > > --===============4012494264293249572==--