Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 742C810584 for ; Wed, 15 Jan 2014 22:03:21 +0000 (UTC) Received: (qmail 66354 invoked by uid 500); 15 Jan 2014 22:03:20 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 66184 invoked by uid 500); 15 Jan 2014 22:03:20 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 65976 invoked by uid 99); 15 Jan 2014 22:03:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jan 2014 22:03:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 535391D435C; Wed, 15 Jan 2014 22:03:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1893463055521453043==" MIME-Version: 1.0 Subject: Re: Review Request 16064: Catch-up Replicated Log 4.1: Added a watch function to watch for network size changes. From: "Benjamin Hindman" To: "Jiang Yan Xu" , "Benjamin Hindman" , "Ben Mahler" Cc: "Jie Yu" , "mesos" Date: Wed, 15 Jan 2014 22:03:19 -0000 Message-ID: <20140115220319.11940.56323@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/16064/ X-Sender: "Benjamin Hindman" References: <20131216200223.11662.69320@reviews.apache.org> In-Reply-To: <20131216200223.11662.69320@reviews.apache.org> Reply-To: "Benjamin Hindman" X-ReviewRequest-Repository: mesos-git --===============1893463055521453043== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16064/#review31943 ----------------------------------------------------------- src/log/network.hpp There is actually a leak here (and other places in the code) where the future might get discarded but we keep the watch in the list. - Benjamin Hindman On Dec. 16, 2013, 8:02 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16064/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 8:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Bugs: MESOS-736 > https://issues.apache.org/jira/browse/MESOS-736 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/network.hpp d34cf78 > src/tests/log_tests.cpp ff5f86c > > Diff: https://reviews.apache.org/r/16064/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============1893463055521453043==--