mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 16150: Containerizer - isolators (part 3)
Date Sun, 26 Jan 2014 08:08:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review32792
-----------------------------------------------------------

Ship it!


Looks great!


src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61765>

    "states" plural



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61766>

    Should the CommandInfo comment go with the isolate() method that returns the CommandInfo?



src/slave/container/isolator.cpp
<https://reviews.apache.org/r/16150/#comment61767>

    Needs newline at end of file



src/slave/container/isolators/posix.hpp
<https://reviews.apache.org/r/16150/#comment61769>

    Neither parameter is used here. Could you comment why update does nothing?


- Adam B


On Jan. 21, 2014, 11:34 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16150/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 11:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas Nielsen, samya,
and Jason Dusek.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Isolators perform isolator for the MesosContainerizer
> 
> Isolator interface and implementations of Posix CPU and Mem isolators (no isolation,
just usage())
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 
>   src/slave/container/isolator.hpp PRE-CREATION 
>   src/slave/container/isolator.cpp PRE-CREATION 
>   src/slave/container/isolators/posix.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message