mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 17304: Added a child Reaper utility in libprocess.
Date Fri, 24 Jan 2014 17:46:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17304/#review32723
-----------------------------------------------------------



3rdparty/libprocess/include/process/reaper.hpp
<https://reviews.apache.org/r/17304/#comment61672>

    Is this comment redundant now since we only wait on explicitly registered pids?



3rdparty/libprocess/src/reaper.cpp
<https://reviews.apache.org/r/17304/#comment61673>

    Out of curiosity, why was 1 second originally chosen?



3rdparty/libprocess/src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/17304/#comment61674>

    s/grand child/grandchild/



3rdparty/libprocess/src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/17304/#comment61675>

    s/grand child/grandchild/



3rdparty/libprocess/src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/17304/#comment61676>

    s/grand child/grandchild/



3rdparty/libprocess/src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/17304/#comment61677>

    s/executor/child/?



3rdparty/libprocess/src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/17304/#comment61678>

    s/grand child/child/


- Ian Downes


On Jan. 24, 2014, 7:05 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17304/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 7:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-943
>     https://issues.apache.org/jira/browse/MESOS-943
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is a copy of the Reaper from Mesos, with one key difference: This now only reaps
pids that were monitored explicitly.
> 
> The test needed updating to reflect the fact that we can now retrieve the exit status
for an already exited process.
> 
> This also opens up the opportunity to eliminate the 1 second delay in the Reaper (using
threads or SIGCHLD), but this is a copy of the Mesos Reaper for now.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 40f01a7b3803696ccca440c8326e1d6d7c377459 
>   3rdparty/libprocess/include/process/reaper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/reaper.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/reaper_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17304/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message