mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 17130: Removal of --without-curl
Date Wed, 22 Jan 2014 23:15:28 GMT


> On Jan. 21, 2014, 6:34 p.m., Ben Mahler wrote:
> > configure.ac, line 599
> > <https://reviews.apache.org/r/17130/diff/1/?file=432899#file432899line599>
> >
> >     Can you kill the whitespace here and below?
> 
> Timothy St. Clair wrote:
>     Can't we add a pre-commit hook script to fix a lot of style questions and automate
this?

Seems good to me. In the past we had thought about putting these kinds of checks into post-reviews.py
to catch things before the review is published.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17130/#review32388
-----------------------------------------------------------


On Jan. 22, 2014, 8 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17130/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 8 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Bugs: MESOS-925
>     https://issues.apache.org/jira/browse/MESOS-925
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> removal of --without-curl 
> 
> 
> Diffs
> -----
> 
>   configure.ac 9f96b7d 
> 
> Diff: https://reviews.apache.org/r/17130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message