mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 16064: Catch-up Replicated Log 4.1: Added a watch function to watch for network size changes.
Date Wed, 15 Jan 2014 22:03:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16064/#review31943
-----------------------------------------------------------



src/log/network.hpp
<https://reviews.apache.org/r/16064/#comment60697>

    There is actually a leak here (and other places in the code) where the future might get
discarded but we keep the watch in the list.


- Benjamin Hindman


On Dec. 16, 2013, 8:02 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16064/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-736
>     https://issues.apache.org/jira/browse/MESOS-736
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/network.hpp d34cf78 
>   src/tests/log_tests.cpp ff5f86c 
> 
> Diff: https://reviews.apache.org/r/16064/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message