mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 16476: Added a script to automate voting a release candidate.
Date Wed, 15 Jan 2014 02:46:10 GMT


> On Jan. 10, 2014, 7:46 p.m., Ben Mahler wrote:
> > support/vote.sh, line 56
> > <https://reviews.apache.org/r/16476/diff/2/?file=403882#file403882line56>
> >
> >     I think people will hit ENTER here blindly, would it be easy to loop until a
non-empty string is read?

good point. done.


> On Jan. 10, 2014, 7:46 p.m., Ben Mahler wrote:
> > support/vote.sh, line 59
> > <https://reviews.apache.org/r/16476/diff/2/?file=403882#file403882line59>
> >
> >     s/Now build/Building/ ?

done


> On Jan. 10, 2014, 7:46 p.m., Ben Mahler wrote:
> > support/vote.sh, line 64
> > <https://reviews.apache.org/r/16476/diff/2/?file=403882#file403882line64>
> >
> >     s/Now let's sign/Signing/ ?

done


> On Jan. 10, 2014, 7:46 p.m., Ben Mahler wrote:
> > support/vote.sh, line 69
> > <https://reviews.apache.org/r/16476/diff/2/?file=403882#file403882line69>
> >
> >     s/And let's create/Creating/ ?

done


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16476/#review31531
-----------------------------------------------------------


On Dec. 27, 2013, 8:04 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16476/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-756
>     https://issues.apache.org/jira/browse/MESOS-756
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is the 2nd script that I mentioned in the ticket.
> 
> 
> Diffs
> -----
> 
>   support/vote.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16476/diff/
> 
> 
> Testing
> -------
> 
> Successfully created a release candidate (0.15.0-rc5) and emailed.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message