mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charlie Carson" <ccar...@twitter.com>
Subject Re: Review Request 16839: Add post function to http.hpp of libprocess.
Date Wed, 15 Jan 2014 01:42:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16839/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 1:42 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Jeff Currier, and Jie Yu.


Changes
-------

  Incorporate CR feedback.

    Renamed internal::httpRequest to just be internal::request.

    Changed internal::request to take Option<string> so that None
    indicates no body / query instead of empty string.


Bugs: https://issues.apache.org/jira/browse/MESOS-902
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-902


Repository: mesos-git


Description
-------

   Add post function to http.hpp of libprocess.

    This adds the post equivalent of the get function to http.hpp.

    The existing get method is refactored into internal::httpRequest
    with arguments for method, query, and body.

    The get and post functions can then be implemented as simple
    wrapper of internal::httpRequest.

    There are also new unit tests to verify the existing behavior of
    get and the new post behavior.

    See:  https://issues.apache.org/jira/browse/MESOS-902

    Review: https://reviews.apache.org/r/16839


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp 67f7f9b 

Diff: https://reviews.apache.org/r/16839/diff/


Testing
-------

added new unit tests
make check


Thanks,

Charlie Carson


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message