mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 16590: LeaderContender::withdraw() now always return ‘false’ if there is no membership to withdraw.
Date Wed, 15 Jan 2014 00:51:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16590/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 4:51 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-892
    https://issues.apache.org/jira/browse/MESOS-892


Repository: mesos-git


Description
-------

This includes when:
- withdraw() is called before contend()
- withdraw() is called after contend() but before the contender learns that it fails to obtain
the candidacy
- withdraw() is called after the contender has learned that it had failed to obtain the candidacy


Diffs (updated)
-----

  src/tests/zookeeper_tests.cpp 94d324a355b4d2189c317d73df0a174ccc38a853 
  src/zookeeper/contender.hpp f45c0dfee4d41e269996a94cfbed71e878c76b13 
  src/zookeeper/contender.cpp e857afa033bcaef06e38da997bd0c947c6153b21 

Diff: https://reviews.apache.org/r/16590/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message