mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 16590: LeaderContender::withdraw() now always return ‘false’ if there is no membership to withdraw.
Date Tue, 14 Jan 2014 20:22:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16590/#review31674
-----------------------------------------------------------

Ship it!


Took a look with Vinod, just one comment from my initial look.


src/zookeeper/contender.hpp
<https://reviews.apache.org/r/16590/#comment60505>

    or because there's nothing to withdraw? 
    
    Saying not contended _yet_ seems to suggest an impending operation.


- Ben Mahler


On Jan. 3, 2014, 10:45 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16590/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 10:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This includes when:
> - withdraw() is called before contend()
> - withdraw() is called after contend() but before the contender learns that it fails
to obtain the candidacy
> - withdraw() is called after the contender has learned that it had failed to obtain the
candidacy
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper_tests.cpp 94d324a355b4d2189c317d73df0a174ccc38a853 
>   src/zookeeper/contender.hpp f45c0dfee4d41e269996a94cfbed71e878c76b13 
>   src/zookeeper/contender.cpp e857afa033bcaef06e38da997bd0c947c6153b21 
> 
> Diff: https://reviews.apache.org/r/16590/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message