mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 16664: Added --with-cxx11 to Mesos configuration.
Date Sat, 11 Jan 2014 00:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16664/#review31562
-----------------------------------------------------------

Ship it!


- Ben Mahler


On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16664/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 7:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> When building with clang we assume --with-cxx11. For example:
>     
>   CC=/path/to/clang CXX=/path/to/clang++ ../configure
>     
> But when building with gcc 4.8 you need to specify C++11:
>     
>   CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11
>     
> At this point in time compiling using C++11 with gcc 4.8 on OS X does not work with Python
so it is explicitely disabled.
> 
> 
> Diffs
> -----
> 
>   configure.ac f69908af84882088ccbf14f89cf46c3a5364cabf 
>   m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16664/diff/
> 
> 
> Testing
> -------
> 
> $ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check
> $ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message