-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/#review31168
-----------------------------------------------------------
Ship it!
src/linux/cgroups.cpp
<https://reviews.apache.org/r/16625/#comment59549>
Add a comment here
# Get the subsystems attached to the hierarchy.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/16625/#comment59550>
How about return Failure if busy.isError() instead?
- Vinod Kone
On Jan. 3, 2014, 9:51 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16625/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-891
> https://issues.apache.org/jira/browse/MESOS-891
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Otherwise the subsystems could still be attached when cleanup() exits and subsequent
mount can fail.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a
>
> Diff: https://reviews.apache.org/r/16625/diff/
>
>
> Testing
> -------
>
> make check
> ./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover --gtest_repeat=100
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
|