mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 16592: Fixed an incorrect CHECK in MesosSchedulerDriver::stop that assumes ‘process’ is always instantiated.
Date Fri, 03 Jan 2014 00:44:43 GMT


> On Jan. 3, 2014, 12:34 a.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 1245
> > <https://reviews.apache.org/r/16592/diff/2/?file=413868#file413868line1245>
> >
> >     s/instantiate/spawn/ ?
> >

Spawn in libprocess's terminology means it is 'process::spawn()'ed, right? Here we are referring
to whether the object is created so I chose 'instantiate'. Sounds Ok? Or it can be just 'create'.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16592/#review31094
-----------------------------------------------------------


On Jan. 3, 2014, 12:18 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16592/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 12:18 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-889
>     https://issues.apache.org/jira/browse/MESOS-889
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp c01e5645a4383f244b3a6b64dfa7d48d9008b9da 
> 
> Diff: https://reviews.apache.org/r/16592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message