Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5E2310185 for ; Fri, 13 Dec 2013 19:32:14 +0000 (UTC) Received: (qmail 14034 invoked by uid 500); 13 Dec 2013 19:32:14 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 13977 invoked by uid 500); 13 Dec 2013 19:32:14 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 13965 invoked by uid 99); 13 Dec 2013 19:32:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 19:32:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 011331D3E58; Fri, 13 Dec 2013 19:32:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4860779527752719363==" MIME-Version: 1.0 Subject: Re: Review Request 16235: Added os::bootId. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" , "Ian Downes" Date: Fri, 13 Dec 2013 19:32:13 -0000 Message-ID: <20131213193213.27438.28718@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/16235/ X-Sender: "Ben Mahler" References: <20131213051519.3768.27649@reviews.apache.org> In-Reply-To: <20131213051519.3768.27649@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============4860779527752719363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 13, 2013, 5:15 a.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 925 > > > > > > Move endutxent() above here so it's always closed? Thank you! My plan is to re-work this to support OS X (via sysctl) / Linux (via uuid) and leave POSIX as a TODO due to the thread safety issues of utmpx. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16235/#review30332 ----------------------------------------------------------- On Dec. 13, 2013, 4:25 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16235/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 4:25 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-844 > https://issues.apache.org/jira/browse/MESOS-844 > > > Repository: mesos-git > > > Description > ------- > > This can be used to identify a reboot, should the boot id change. > > For POSIX systems, the boot time in seconds is used as a good approximation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2382d40a51036782e09e1fc3123c8791834510ea > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp a0b624b0c2e1f1fca6dd68a54317f6c0c11e7862 > > Diff: https://reviews.apache.org/r/16235/diff/ > > > Testing > ------- > > Added a test, make check on OS X and CentOS 5. > > > Thanks, > > Ben Mahler > > --===============4860779527752719363==--