mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 16332: Added equality comparator for Option<T> vs T.
Date Tue, 17 Dec 2013 23:35:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16332/#review30581
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
<https://reviews.apache.org/r/16332/#comment58572>

    Any reason not to do:
    
    Option<Option<int> > someNone1 = Some(None());
    Option<Option<int> > noneNone1 = None();


- Benjamin Hindman


On Dec. 17, 2013, 11:21 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16332/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 11:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Used in a future patch to compare "UPID from" with "Option<UPID> master".
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f12c0cafad141fe8857fbc14624ce43e3de77171

>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp bda06104f30d7358e0f8829e62e5363954355658

> 
> Diff: https://reviews.apache.org/r/16332/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message